Skip to content

protocols: implement image-capture-source-v1 and image-copy-capture-v1 #11709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

protocols: implement image-capture-source-v1 and image-copy-capture-v1 #11709

wants to merge 7 commits into from
+2,322 −1,008

Conversation

@ikalco
Copy link
Contributor

@ikalco ikalco commented Sep 15, 2025 •
edited
Loading

Describe your PR, what does it fix/add?

implement the image-capture-source-v1 and image-copy-capture-v1 protocols

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

do you want me to split into separate PRs?

also how should we do permissions?
either error on image source creation, or do like screencopy and allow the source but render denied screen

Is it ready for merging, or does it need work?

ready from my testing

@ikalco ikalco force-pushed the image_capture_proto branch from c07137b to 0169424 Compare September 15, 2025 22:09
@vaxerski
Copy link
Member

vaxerski commented Sep 15, 2025

I almost shat myself and thought someone random would write a bad impl

then I noticed it's ikalco 🥰

I think we should unify screencopy at this point. Protocol files should have 0 rendering code, and instead that would be delegated to a global sharing mgr.

One MR is ok. Maybe keep commits making sense though.

also how should we do permissions?

black until allowed/denied, if denied keep rendering black but with a "screencast denied" text. IIRC thats how it is rn.

@vaxerski
Copy link
Member

vaxerski commented Sep 17, 2025

ping me for review when ready

@ikalco ikalco force-pushed the image_capture_proto branch 2 times, most recently from 94f3b2f to 861fd28 Compare September 18, 2025 02:34
@ikalco ikalco force-pushed the image_capture_proto branch 2 times, most recently from 7ea28e1 to bba00a6 Compare October 5, 2025 07:15
@arrowpc
Copy link
Contributor

arrowpc commented Oct 16, 2025

I could help out with this if wanted. I already hacked together a complete implementation for Hyprland 2 months ago or so to test out a library I'm working on. Every compositor either had a poor implementation or an incomplete one so I couldn't test anything reliably.

@ikalco ikalco force-pushed the image_capture_proto branch from 77ba086 to 09ce282 Compare October 17, 2025 19:24
@ikalco ikalco force-pushed the image_capture_proto branch 3 times, most recently from 1bf6cc0 to 9f6abae Compare November 11, 2025 02:35
@ikalco ikalco marked this pull request as ready for review November 11, 2025 02:41
@ikalco ikalco force-pushed the image_capture_proto branch from 9f6abae to 558f178 Compare December 2, 2025 18:42
@ikalco ikalco force-pushed the image_capture_proto branch from 558f178 to 4615e8a Compare December 2, 2025 22:54
@ikalco ikalco force-pushed the image_capture_proto branch from 4615e8a to 19f32ae Compare December 2, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

config core desktop events helpers managers protocols render

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ikalco @vaxerski @arrowpc